test(mcms): replace legacy changeset usage#115
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates MCMS integration/unit tests to stop relying on legacy/mcms/changesets and instead use the newer mcms/changesets/* implementations, aligning test coverage with the migrated changeset APIs and datastore-based address resolution.
Changes:
- Replace legacy
DeployMCMSWithTimelockV2usage in Solana/EVM tests withmcms/changesets/deploy. - Replace legacy transfer-to-timelock flows with
mcms/changesets/transfer-to-timelockand refkey-based contract selection. - Update Solana test runtimes to seed a datastore (program IDs) via
solanatest.NewDataStoreWithMCMSProgramsrather than using an AddressBook.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| mcms/solana/grant-role/sequence_test.go | Switches runtime setup and transfer-to-timelock flow to new deploy + transfer changesets and datastore-based state loading. |
| mcms/solana/firedrill/changeset_test.go | Migrates Solana firedrill test runtime bootstrap to new deploy changeset + seeded datastore. |
| mcms/solana/changesets/fund-mcm-pdas/changeset_test.go | Removes legacy AddressBook wiring from test runtime creation (tests explicitly set datastore on the environment). |
| mcms/evm/set-config/sequence_test.go | Removes legacy-based helpers, keeping focused unit tests for ref resolution / error paths. |
| mcms/evm/set-config/operation_test.go | Moves operation tests to an external test package and updates to new deploy-based runtime setup. |
| mcms/evm/set-config/changeset_test.go | Migrates deploy + transfer-to-timelock setup and updates state/address access patterns to use ref resolution. |
| mcms/evm/grant-role/sequence_test.go | Switches EVM grant-role runtime bootstrap to the new deploy changeset. |
| mcms/evm/firedrill/changeset_test.go | Switches EVM firedrill runtime bootstrap to the new deploy changeset. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
graham-chainlink
force-pushed
the
ggoh/mcms/remove-legacy
branch
from
161e2cd to
1e5bc0a
Compare
There was a problem hiding this comment.
tests moved from sequence_test.go to here and changing it so it covers changeset level (integration test)
Release impact (release-please)
PR title: This title will not trigger a semver bump when squash-merged to Conventional commit → bump
Update the PR title before merge if you need a different bump (squash commit message = PR title). Preview is based on this PR title only. The release-please release PR may include other unreleased commits already on |
graham-chainlink
force-pushed
the
ggoh/mcms/remove-legacy
branch
from
1e5bc0a to
c43a861
Compare
product-security-plaid-production
Bot
requested a review
from DimitriosNaikopoulos
In the new changesets under mcms, we should be using the new changesets instead of the legacy changesets
graham-chainlink
force-pushed
the
ggoh/mcms/remove-legacy
branch
from
c43a861 to
975861c
Compare
|
In the new changesets under mcms, we should be using the new changesets instead of the legacy changesets